Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling
Date	2015-10-14 15:40 +0200
Message-ID	<qjurD-8nB-5@gated-at.bofh.it> (permalink)
References	<qcgD7-70f-9@gated-at.bofh.it> <qchSz-gB-21@gated-at.bofh.it> <qjpLj-1t1-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Robert Baldyga <r.baldyga@samsung.com> writes:
> Hi Felipe,
>
> On 09/24/2015 06:49 PM, Felipe Balbi wrote:
>> On Thu, Sep 24, 2015 at 05:23:09PM +0200, Robert Baldyga wrote:
>>> Move function parameters to struct f_sourcesink to make them per instance
>>> instead of having them as global variables. Since we can have multiple
>>> instances of USB function we also want to have separate set of parameters
>>> for each instance.
>>>
>>> Cc: <stable@vger.kernel.org> # 3.10+
>>> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
>> 
>> why do you think this is stable material ? Looks like it's not
>> fixing anything to me; just implementing a brand new requirement.
>
> I will not insist on stable backporting of this patch, as it's actually
> not very important fix (especially in case of sourcesink function).
>
> Should I resend this patch without CC:stable?

please, thank you.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling Robert Baldyga <r.baldyga@samsung.com> - 2015-10-14 10:40 +0200
  Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling Felipe Balbi <balbi@ti.com> - 2015-10-14 15:40 +0200

csiph-web