Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts

From	Vignesh R <vigneshr@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts
Date	2015-10-14 13:40 +0200
Message-ID	<qjszv-5BO-1@gated-at.bofh.it> (permalink)
References	<qjngu-6a6-11@gated-at.bofh.it> <qjpV0-1Es-21@gated-at.bofh.it> <qjqo2-2sC-13@gated-at.bofh.it> <qjs6t-52j-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 10/14/2015 04:34 PM, Roger Quadros wrote:
> Vignesh,
> 
> On 14/10/15 12:12, Vignesh R wrote:
>>
>>
>> On 10/14/2015 02:16 PM, Roger Quadros wrote:
>>
>>>
>>> On 14/10/15 08:52, Vignesh R wrote:
>>>> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power
>>>> state via pinctrl and IO daisy chain using generic wakeirq framework.
>>>> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup
>>>> interrupt in device tree") i2c core allows optional wakeirq to be
>>>> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts
>>>> to wake the system from low power state.
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>>> ---
>>>>  arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>>>> index 22038f21f228..69e93af7df0d 100644
>>>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>>>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>>>> @@ -581,8 +581,13 @@
>>>>  
>>>>  		attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>>>>  
>>>> +		interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>,
>>>> +				      <&am43xx_pinmux 0x264>;
>>>
>>> How does this work?
>>>
>>> interrupts-extended property must have
>>> 1) interrupt parent
>>> 2) interrupt number
>>> 3) interrupt flags
>>>
>>> Your change doesn't seem to comply with those requirements.
>>
>> AFAIU, interrupts-extended has two parts: interrupt parent phandle and
>> interrupt specifier.
>> The number of cells in interrupt specifier is determined by
>> interrupt-cells property of interrupt parent node.
> 
> Got it.
> 
>> In above case, gpio3 has interrupt-cells = 2 hence interrupt specifier
>> has interrupt number and interrupt flag field.
> 
> But is GPIO_ACTIVE_HIGH an interrupt flag?

Oops.. I will change it to IRQ_TYPE_NONE as represented in interrupts
property.

> 
>> But in case am43xx_pinmux node, interrupt-cells is 1 hence has no
>> interrupt flag field.
>>
> Understood, thanks. Might be worth adding a comment as to what 0x264 means though.
> 

Will add a one line comment indicating its the offset of gpio3_22
padconf register from am43xx_pinmux base.

> cheers,
> -roger
> 

-- 
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts Vignesh R <vigneshr@ti.com> - 2015-10-14 08:00 +0200
  Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for  pixcir_i2c_ts Roger Quadros <rogerq@ti.com> - 2015-10-14 10:50 +0200
    Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for  pixcir_i2c_ts Vignesh R <vigneshr@ti.com> - 2015-10-14 11:20 +0200
      Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for  pixcir_i2c_ts Roger Quadros <rogerq@ti.com> - 2015-10-14 13:10 +0200
        Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for  pixcir_i2c_ts Vignesh R <vigneshr@ti.com> - 2015-10-14 13:40 +0200

csiph-web