Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Date	Wed, 14 Oct 2015 14:00:02 +0200
Message-ID	<qjsSS-5ZS-13@gated-at.bofh.it> (permalink)
References	<qjrN8-4ow-1@gated-at.bofh.it> <qjrN9-4ow-23@gated-at.bofh.it> <qjsga-5dK-13@gated-at.bofh.it> <qjspR-5qz-41@gated-at.bofh.it> <qjszw-5BO-19@gated-at.bofh.it>
X-Original-To	Sebastian Reichel <sre@kernel.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HFrbafkpcbxjMNtDC6o3tSkNpaimdLOiL"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	68
Organization	linux.* mail to news gateway
X-Original-Cc	<tony@atomide.com>, <pavel@ucw.cz>, <pali.rohar@gmail.com>, <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 14 Oct 2015 14:54:53 +0300
X-Original-Message-ID	<561E428D.4030305@ti.com>
X-Original-References	<1444819456-26728-1-git-send-email-rogerq@ti.com> <1444819456-26728-3-git-send-email-rogerq@ti.com> <20151014111939.GB14340@earth> <561E3C1F.5000406@ti.com> <20151014113736.GC14340@earth>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1246598

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On 14/10/15 14:37, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Oct 14, 2015 at 02:27:27PM +0300, Roger Quadros wrote:
>> On 14/10/15 14:19, Sebastian Reichel wrote:
>>> On Wed, Oct 14, 2015 at 01:44:16PM +0300, Roger Quadros wrote:
>>>> Let's keep the SSI ports disabled in the omap3.dtsi to avoid
>>>> getting the following noise on the console for boards that don't
>>>> use the SSI ports.
>>>>
>>>> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"
>>>>
>>>> As omap3-n900 uses one SSI port, mark it enabled there.
>>
>> Would it be preferable to disable the ssi-controller node as well in the
>> omap3.dtsi file?
> 
> If I remember it correctly, existing, but unused IP-Cores
> should not be disabled in DT, so that hwmod picks them up
> for power management.

OK.
> 
> Note, that it actually is disabled in omap3.dtsi and then enabled in
> omap34xx/omap36xx dts files (the other variants do not have an ssi
> module).

Thanks for the info :)

cheers,
-roger

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] omap: hsi: Fix warnings on boards that don't use ssi ports Roger Quadros <rogerq@ti.com> - 2015-10-14 12:50 +0200
  [PATCH 1/2] hsi: omap_ssi_port: Prevent warning if cawake_gpio is not defined. Roger Quadros <rogerq@ti.com> - 2015-10-14 12:50 +0200
    Re: [PATCH 1/2] hsi: omap_ssi_port: Prevent warning if cawake_gpio  is not defined. Sebastian Reichel <sre@kernel.org> - 2015-10-14 13:50 +0200
  [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Roger Quadros <rogerq@ti.com> - 2015-10-14 12:50 +0200
    Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Pali Rohár <pali.rohar@gmail.com> - 2015-10-14 13:00 +0200
      Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Sebastian Reichel <sre@kernel.org> - 2015-10-14 13:20 +0200
    Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Sebastian Reichel <sre@kernel.org> - 2015-10-14 13:20 +0200
      Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Roger Quadros <rogerq@ti.com> - 2015-10-14 13:30 +0200
        Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Sebastian Reichel <sre@kernel.org> - 2015-10-14 13:40 +0200
          Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Roger Quadros <rogerq@ti.com> - 2015-10-14 14:00 +0200

csiph-web