Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1246596
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT |
| Date | 2015-10-14 14:00 +0200 |
| Message-ID | <qjsSR-5ZS-9@gated-at.bofh.it> (permalink) |
| References | <qiWJk-8ld-3@gated-at.bofh.it> <qiWSZ-4U-11@gated-at.bofh.it> <qjszw-5BO-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Franklin,
On 14/10/15 14:36, Roger Quadros wrote:
> On 13/10/15 04:38, Franklin S Cooper Jr wrote:
>> Switch from dma_request_channel to allow passing dma channel
>> information from DT rather than hardcoding a value.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>
> Acked-by: Roger Quadros <rogerq@ti.com>
>
>> ---
>> drivers/mtd/nand/omap2.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index d0f2620..957c32f 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -1866,7 +1866,9 @@ static int omap_nand_probe(struct platform_device *pdev)
>> dma_cap_zero(mask);
>> dma_cap_set(DMA_SLAVE, mask);
>> sig = OMAP24XX_DMA_GPMC;
>> - info->dma = dma_request_channel(mask, omap_dma_filter_fn, &sig);
>> + info->dma = dma_request_slave_channel_compat(mask,
>> + omap_dma_filter_fn, &sig, pdev->dev.parent, "rxtx");
>> +
Just discovered that you are using the parent device node.
How about moving the dma bindings to the nand node instead and using
pdev->dev here?
>> if (!info->dma) {
>> dev_err(&pdev->dev, "DMA engine request failed\n");
>> err = -ENXIO;
>>
>
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] mtd: nand: Fix support for NAND DMA Prefetch Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-13 03:40 +0200
[PATCH 3/5] mtd: nand: omap2: Fix high memory dma prefetch transfer Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-13 03:40 +0200
[PATCH 5/5] ARM: OMAP2+: Update gpmc and nand DT binding documentation Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-13 03:40 +0200
Re: [PATCH 5/5] ARM: OMAP2+: Update gpmc and nand DT binding documentation Roger Quadros <rogerq@ti.com> - 2015-10-14 14:00 +0200
Re: [PATCH 5/5] ARM: OMAP2+: Update gpmc and nand DT binding documentation "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-15 19:20 +0200
[PATCH 4/5] ARM: dts: am437x/am33xx/omap3/dm816x: Add gpmc dma channel Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-13 03:40 +0200
Re: [PATCH 4/5] ARM: dts: am437x/am33xx/omap3/dm816x: Add gpmc dma channel Roger Quadros <rogerq@ti.com> - 2015-10-14 13:50 +0200
Re: [PATCH 4/5] ARM: dts: am437x/am33xx/omap3/dm816x: Add gpmc dma channel "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-14 16:00 +0200
[PATCH 2/5] mtd: nand: omap2: Start dma request before enabling prefetch Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-13 03:50 +0200
Re: [PATCH 2/5] mtd: nand: omap2: Start dma request before enabling prefetch Roger Quadros <rogerq@ti.com> - 2015-10-14 13:50 +0200
Re: [PATCH 2/5] mtd: nand: omap2: Start dma request before enabling prefetch "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-14 15:50 +0200
[PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-13 03:50 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Roger Quadros <rogerq@ti.com> - 2015-10-14 13:40 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Roger Quadros <rogerq@ti.com> - 2015-10-14 14:00 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-14 15:30 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Roger Quadros <rogerq@ti.com> - 2015-10-14 16:20 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-14 16:40 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Tony Lindgren <tony@atomide.com> - 2015-10-14 18:20 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-14 18:30 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Tony Lindgren <tony@atomide.com> - 2015-10-14 20:20 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-14 22:10 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Roger Quadros <rogerq@ti.com> - 2015-10-15 09:40 +0200
Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-15 19:20 +0200
csiph-web