Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1246432

Re: [PATCH v2 1/2] sched: make each sched class handle its rq assignment in their own class

Show all headers | View raw

On Wed, Oct 14, 2015 at 05:42:09PM +0900, byungchul.park@lge.com wrote:
> +static inline void set_task_rq(struct task_struct *p, unsigned int cpu)
> +{
> +	const struct sched_class *class;
> +
> +	for_each_class(class) {
> +		if (class->set_task_rq)
> +			class->set_task_rq(p, cpu);
> +	}
> +}

So I worry about this, because the class structures are not all in the
same translation unit, GCC cannot (without -fwhole-program) optimize
that all away.

This means we'll do 5 cacheline loads and 2 indirect calls, on _every_
cpu migration.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] sched: account fair load avg consistently <byungchul.park@lge.com> - 2015-10-14 10:50 +0200
  [PATCH v2 1/2] sched: make each sched class handle its rq assignment in their own class <byungchul.park@lge.com> - 2015-10-14 10:50 +0200
    Re: [PATCH v2 1/2] sched: make each sched class handle its rq  assignment in their own class Peter Zijlstra <peterz@infradead.org> - 2015-10-14 11:10 +0200
      Re: [PATCH v2 1/2] sched: make each sched class handle its rq  assignment in their own class Byungchul Park <byungchul.park@lge.com> - 2015-10-14 11:30 +0200
        Re: [PATCH v2 1/2] sched: make each sched class handle its rq  assignment in their own class Peter Zijlstra <peterz@infradead.org> - 2015-10-14 11:40 +0200
          Re: [PATCH v2 1/2] sched: make each sched class handle its rq  assignment in their own class Byungchul Park <byungchul.park@lge.com> - 2015-10-14 12:20 +0200

csiph-web