Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD

From	Pan Xinhui <xinhuix.pan@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD
Date	2015-10-14 10:50 +0200
Message-ID	<qjpV0-1Es-19@gated-at.bofh.it> (permalink)
References	<qjmX7-5Me-9@gated-at.bofh.it> <qjoPf-8w0-21@gated-at.bofh.it> <qjpBE-1hT-23@gated-at.bofh.it> <qjpLk-1t1-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2015年10月14日 16:38, Michal Hocko wrote:
> On Wed 14-10-15 16:17:31, Pan Xinhui wrote:
> [...]
>> I have a look at Mel's patchset. yes, it can help fix my kswapd issue.
>> :) So I just need change my kmalloc's gfp_flag to GFP_ATOMIC &~
>> __GFP_KSWAPD_RECLAIM, then slub will not wakeup kswpad.
> 
> As pointed out in my other email __GFP_ATOMIC would be more appropriate
> because you shouldn't abuse memory reserves which are implicitly used
> for GFP_ATOMIC requests.
> 

oh, yes. maybe it's better to use (__GFP_HIGH | __GFP_ATOMIC) than (GFP_ATOMIC &~ __GFP_KSWAPD_RECLAIM)..
just set the gfp flags which I need in kmalloc.

thanks for the suggestion.

thanks
xinhui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Pan Xinhui <xinhuix.pan@intel.com> - 2015-10-14 07:40 +0200
  Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Pan Xinhui <xinhuix.pan@intel.com> - 2015-10-14 08:10 +0200
    Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Michal Hocko <mhocko@kernel.org> - 2015-10-14 09:50 +0200
      Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Pan Xinhui <xinhuix.pan@intel.com> - 2015-10-14 10:40 +0200
  Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Michal Hocko <mhocko@kernel.org> - 2015-10-14 09:40 +0200
    Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Pan Xinhui <xinhuix.pan@intel.com> - 2015-10-14 10:30 +0200
      Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Michal Hocko <mhocko@kernel.org> - 2015-10-14 10:40 +0200
        Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Pan Xinhui <xinhuix.pan@intel.com> - 2015-10-14 10:50 +0200

csiph-web