Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG
Date	2015-10-14 09:40 +0200
Message-ID	<qjoPf-8w0-19@gated-at.bofh.it> (permalink)
References	<qfBL4-4es-5@gated-at.bofh.it> <qiGEx-1LJ-11@gated-at.bofh.it> <qiGEy-1LJ-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 12, 2015 at 10:21 AM, Daniel Thompson
<daniel.thompson@linaro.org> wrote:

> Add support for STMicroelectronics STM32 random number generator.
>
> The config value defaults to N, reflecting the fact that STM32 is a
> very low resource microcontroller platform and unlikely to be targeted
> by any "grown up" defconfigs.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

This is a fine driver, love the performance boost you reported
and stand corrected on the likeness of the other Nomadik driver.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

> +static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)

Now this read() function is so nice that I feel obliged to
go in and tidy up the Nomadik driver to be as nice.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/3] hwrng: stm32 - add support for STM32 HW RNG Daniel Thompson <daniel.thompson@linaro.org> - 2015-10-12 10:30 +0200
  [PATCH 1/3] dt-bindings: Document the STM32 HW RNG bindings Daniel Thompson <daniel.thompson@linaro.org> - 2015-10-12 10:30 +0200
  [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG Daniel Thompson <daniel.thompson@linaro.org> - 2015-10-12 10:30 +0200
    Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG Linus Walleij <linus.walleij@linaro.org> - 2015-10-14 09:40 +0200
  Re: [PATCH 0/3] hwrng: stm32 - add support for STM32 HW RNG Herbert Xu <herbert@gondor.apana.org.au> - 2015-10-14 16:30 +0200
    Re: [PATCH 0/3] hwrng: stm32 - add support for STM32 HW RNG Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-10-14 16:50 +0200

csiph-web