Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.
Date	2015-10-14 03:20 +0200
Message-ID	<qjiTw-7z2-1@gated-at.bofh.it> (permalink)
References	<qjfCh-2k3-3@gated-at.bofh.it> <qjfCj-2k3-19@gated-at.bofh.it> <qjgf0-3jk-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2015-10-13 at 15:23 -0700, Alexander Duyck wrote:
> Please don't just blindly 
> follow checkpatch as it can give out erroneous information.
> 
> Looking over most of this patch series it seems like it is taking 
> readability in the wrong direction and reducing the ability to maintain 
> the driver since this code has been "maintenance only" for some time 
> now.  If somebody comes up with a legitimate fix for an issue at some 
> point in the future they will need to work around these patches in order 
> to back-port it into a stable release and that just hurts maintainability.
> 
> I'd say this whole series should be rejected on the grounds that this 
> driver is mostly stable and should only really be modified for bug fixes 
> at this point.  If we really need to go through and do a checkpatch 
> sweep we should probably just focus on serious errors only instead of 
> going astray and chasing down things that are false hits or minor issues 
> that are mostly a matter of preference.

Excellent advice.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/6] e1000 driver remove checkpatch errors, warnings and checks. Janusz Wolak <januszwolak@awokados.com.pl> - 2015-10-13 23:50 +0200
  [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks. Janusz Wolak <januszwolak@awokados.com.pl> - 2015-10-13 23:50 +0200
    Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and  checks. Alexander Duyck <alexander.duyck@gmail.com> - 2015-10-14 00:30 +0200
      Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and  checks. Joe Perches <joe@perches.com> - 2015-10-14 03:20 +0200
      Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and  checks. Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2015-10-14 07:40 +0200
  [PATCH 4/6] e1000 driver remove checkpatch errors, warnings and checks. Janusz Wolak <januszwolak@awokados.com.pl> - 2015-10-13 23:50 +0200

csiph-web