Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1246030

Re: [PATCH v7 4/5] locking/pvqspinlock: Allow 1 lock stealing attempt

Show all headers | View raw

On Tue, Sep 22, 2015 at 04:50:43PM -0400, Waiman Long wrote:
>  	for (;; waitcnt++) {
> +		loop = SPIN_THRESHOLD;
> +		while (loop) {
> +			/*
> +			 * Spin until the lock is free
> +			 */
> +			for (; loop && READ_ONCE(l->locked); loop--)
> +				cpu_relax();
> +			/*
> +			 * Seeing the lock is free, this queue head vCPU is
> +			 * the rightful next owner of the lock. However, the
> +			 * lock may have just been stolen by another task which
> +			 * has entered the slowpath. So we need to use atomic
> +			 * operation to make sure that we really get the lock.
> +			 * Otherwise, we have to wait again.
> +			 */
> +			if (cmpxchg(&l->locked, 0, _Q_LOCKED_VAL) == 0)
> +				goto gotlock;
>  		}

		for (loop = SPIN_THRESHOLD; loop; --loop) {
			if (!READ_ONCE(l->locked) &&
			    cmpxchg(&l->locked, 0, _Q_LOCKED_VA) == 0)
				goto gotlock;

			cpu_relax();
		}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 4/5] locking/pvqspinlock: Allow 1 lock stealing attempt Peter Zijlstra <peterz@infradead.org> - 2015-10-13 20:30 +0200
  Re: [PATCH v7 4/5] locking/pvqspinlock: Allow 1 lock stealing attempt Waiman Long <waiman.long@hpe.com> - 2015-10-13 22:50 +0200
    Re: [PATCH v7 4/5] locking/pvqspinlock: Allow 1 lock stealing attempt Peter Zijlstra <peterz@infradead.org> - 2015-10-13 22:50 +0200
      Re: [PATCH v7 4/5] locking/pvqspinlock: Allow 1 lock stealing attempt Waiman Long <waiman.long@hpe.com> - 2015-10-15 22:50 +0200

csiph-web