Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1246022

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

Show all headers | View raw

On Oct. Tuesday 13 (42) 10:35 AM, Florian Fainelli wrote:
> On 13/10/15 09:46, Vivien Didelot wrote:
> > There is no need to write the MAC address before every Get Next
> > operation, since ATU MAC registers are not cleared between calls.
> > 
> > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext
> > so future code could call ATU Get Next multiple times and save a few
> > register access.
> 
> Missing SoB tag here.

Damn, good catch. Can I add it in reply to the patch, or should I send a
v3?

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 18:50 +0200
  Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside  of ATU Get Next code Florian Fainelli <f.fainelli@gmail.com> - 2015-10-13 19:40 +0200
    Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside  of ATU Get Next code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 20:20 +0200
      Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside  of ATU Get Next code Florian Fainelli <f.fainelli@gmail.com> - 2015-10-13 20:50 +0200
  Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside  of ATU Get Next code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 20:50 +0200

csiph-web