Re: [PATCH] block-mq:Fix the null memory access while setting tags cpumask

Path	csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod
From	Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block-mq:Fix the null memory access while setting tags cpumask
Date	Tue, 13 Oct 2015 19:30:02 +0200
Message-ID	<qjbyG-4SC-35@gated-at.bofh.it> (permalink)
References	<qj0jU-5h4-3@gated-at.bofh.it> <qjaVY-3T8-27@gated-at.bofh.it>
X-Original-To	Jeff Moyer <jmoyer@redhat.com>
X-Helo	d28dlp03.in.ibm.com
X-Mailfrom	raghavendra.kt@linux.vnet.ibm.com
X-Rcptto	linux-kernel@vger.kernel.org
Organization	IBM
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version	1.0
Content-Type	text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding	7bit
X-Tm-As-Mml	disable
X-Content-Scanned	Fidelis XPS MAILER
X-Cbid	15101317-0005-0000-0000-00000812783E
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
X-Original-Cc	axboe@kernel.dk, linuxppc-dev@lists.ozlabs.org, ming.lei@canonical.com, keith.busch@intel.com, snitzer@redhat.com, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 13 Oct 2015 22:59:37 +0530
X-Original-Message-ID	<561D3F81.3010506@linux.vnet.ibm.com>
X-Original-References	<1444713927-16261-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <x491tcy7m2j.fsf@segfault.boston.devel.redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1245946

Show key headers only | View raw

On 10/13/2015 10:17 PM, Jeff Moyer wrote:
> Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com> writes:
>
>> In nr_hw_queues >1 cases when certain number of cpus are onlined/or
>> offlined, that results change in request_queue map in block-mq layer,
>> we see the kernel dumping like:
>
> What version is that patch against?  This problem should be fixed by the
> patch set from Akinobu Mita.  I tested cpu hot-plugging on my system
> with an nvme device, and it is fixed there on mainline.
>

Hi Jeff,

My patch was against (4.3.0-rc2) bcee19f424a.

I do see now that  commit 1356aae08338 (blk-mq: avoid setting
hctx->tags->cpumask before allocation) has equivalent fix.

Thanks for the information.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block-mq:Fix the null memory access while setting tags cpumask Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com> - 2015-10-13 07:30 +0200
  Re: [PATCH] block-mq:Fix the null memory access while setting tags cpumask Jeff Moyer <jmoyer@redhat.com> - 2015-10-13 18:50 +0200
    Re: [PATCH] block-mq:Fix the null memory access while setting tags  cpumask Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com> - 2015-10-13 19:30 +0200

csiph-web