Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245978

Re: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same}

Show all headers | View raw

On Tue, Oct 13, 2015 at 4:50 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Aug 12, 2015 at 12:07:15AM -0700, Ming Lin wrote:
>> From: Ming Lin <ming.l@ssi.samsung.com>
>>
>> The split code in blkdev_issue_{discard,write_same} can go away
>> now that any driver that cares does the split. We have to make
>> sure bio size doesn't overflow.
>>
>> For discard, we set max discard sectors to (1<<31)>>9 to ensure
>> it doesn't overflow bi_size and hopefully it is of the proper
>> granularity as long as the granularity is a power of two.
>
> This ends up breaking discard on NVMe devices for a me.  An mkfs.xfs
> which does a discard of the whole device now hangs the system.
> Something in here makes it send discard command that the device doesn't
> like and the aborts don't seem to help either, although that might be
> an issue with the abort handling in the driver.
>
> Just a heads up for now, once I get a bit more time I'll try to collect
> a blktrace to figure out how the commands sent to the driver look
> different before and after the patch.

I just did a quick test with a Samsung 900G NVMe device.
mkfs.xfs is OK on 4.3-rc5.

What's your device model? I may find a similar one to try.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 05/11] block: remove split code in  blkdev_issue_{discard,write_same} Christoph Hellwig <hch@infradead.org> - 2015-10-13 14:00 +0200
  Re: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} Ming Lin <mlin@kernel.org> - 2015-10-13 19:50 +0200
    Re: [PATCH v6 05/11] block: remove split code in  blkdev_issue_{discard,write_same} Christoph Hellwig <hch@infradead.org> - 2015-10-14 15:30 +0200
      Re: [PATCH v6 05/11] block: remove split code in  blkdev_issue_{discard,write_same}B Keith Busch <keith.busch@intel.com> - 2015-10-14 18:40 +0200
        Re: [PATCH v6 05/11] block: remove split code in  blkdev_issue_{discard,write_same}B Christoph Hellwig <hch@infradead.org> - 2015-10-14 19:00 +0200

csiph-web