Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1245884

Re: [PATCH net-next 0/6] net: dsa: implement port_fdb_dump in drivers

From Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 0/6] net: dsa: implement port_fdb_dump in drivers
Date 2015-10-13 18:20 +0200
Message-ID <qjasV-3kA-15@gated-at.bofh.it> (permalink)
References <qj9ZU-2xR-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Oct. Tuesday 13 (42) 11:42 AM, Vivien Didelot wrote:
> Not all switch chips provide a Get Next kind of operation to dump FDB entries.
> It is preferred to let the driver handle the dump operation the way it works
> best for the chip. Thus, drop port_fdb_getnext and implement the port_fdb_dump
> operation in DSA, which pushes the switchdev FDB dump callback down to the
> drivers. mv88e6xxx is the only driver affected and is updated accordingly.
> 
> Vivien Didelot (6):
>   net: dsa: mv88e6xxx: write VID outside of VTU Get Next code
>   net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code
>   net: dsa: add port_fdb_dump function
>   net: dsa: mv88e6xxx: implement port_fdb_dump
>   net: dsa: mv88e6xxx: remove port_fdb_getnext
>   net: dsa: remove port_fdb_getnext
> 
>  drivers/net/dsa/mv88e6171.c |   2 +-
>  drivers/net/dsa/mv88e6352.c |   2 +-
>  drivers/net/dsa/mv88e6xxx.c | 140 ++++++++++++++++++++++++--------------------
>  drivers/net/dsa/mv88e6xxx.h |   5 +-
>  include/net/dsa.h           |   8 ++-
>  net/dsa/slave.c             |  26 +-------
>  6 files changed, 90 insertions(+), 93 deletions(-)

I mispaste a few "return err" instead of "goto unlock" which skips a few
mutex_unlock() in mv88e6xxx.c. I'm sending a respin right away, please
ignore this v1.

Sorry,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH net-next 0/6] net: dsa: implement port_fdb_dump in drivers Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 17:50 +0200
  [PATCH net-next 5/6] net: dsa: mv88e6xxx: remove port_fdb_getnext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 17:50 +0200
  [PATCH net-next 2/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 17:50 +0200
  [PATCH net-next 3/6] net: dsa: add port_fdb_dump function Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 17:50 +0200
  [PATCH net-next 1/6] net: dsa: mv88e6xxx: write VID outside of VTU Get Next code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 17:50 +0200
  Re: [PATCH net-next 0/6] net: dsa: implement port_fdb_dump in drivers Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-13 18:20 +0200

csiph-web