[PATCH] mxl111sf: missing return values validation

From	Insu Yun <wuninsu@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] mxl111sf: missing return values validation
Date	2015-10-15 22:30 +0200
Message-ID	<qjXjX-DP-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Return values of mxl111sf_enable_usb_output and mxl1x1sf_top_master_ctrl 
are not validated.

Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
 drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
index bec12b0..b71b2e6 100644
--- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
+++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
@@ -288,9 +288,9 @@ static int mxl111sf_adap_fe_init(struct dvb_frontend *fe)
 	err = mxl1x1sf_set_device_mode(state, adap_state->device_mode);
 
 	mxl_fail(err);
-	mxl111sf_enable_usb_output(state);
+	err = mxl111sf_enable_usb_output(state);
 	mxl_fail(err);
-	mxl1x1sf_top_master_ctrl(state, 1);
+	err = mxl1x1sf_top_master_ctrl(state, 1);
 	mxl_fail(err);
 
 	if ((MXL111SF_GPIO_MOD_DVBT != adap_state->gpio_mode) &&
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mxl111sf: missing return values validation Insu Yun <wuninsu@gmail.com> - 2015-10-15 22:30 +0200
  Re: [PATCH] mxl111sf: missing return values validation Michael Ira Krufky <mkrufky@linuxtv.org> - 2015-10-15 23:30 +0200

csiph-web