Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248179

Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories

Show all headers | View raw

On Thursday, October 15, 2015 12:25:27 PM Saravana Kannan wrote:
> On 10/15/2015 09:05 AM, Viresh Kumar wrote:
> > The cpufreq sysfs interface had been a bit inconsistent as one of the
> > CPUs for a policy had a real directory within its sysfs 'cpuX' directory
> > and all other CPUs had links to it. That also made the code a bit
> > complex as we need to take care of moving the sysfs directory if the CPU
> > containing the real directory is getting physically hot-unplugged.
> >
> > Solve this by creating 'policyX' directories (per-policy) in
> > /sys/devices/system/cpu/cpufreq/ directory, where X is the CPU for which
> > the policy was first created.
> >
> > This also removes the need of keeping kobj_cpu and we can remove it now.
> >
> > Suggested-by: Saravana Kannan <skannan@codeaurora.org>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> 
> Since you've added a separate patch for making policyX more consistent:
> Reviewed-by: Saravana Kannan <skannan@codeaurora.org>
> 
> Btw, does a Review-by have an implicit Acked-by?

Yes it does, at least as far as I'm concerned.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-15 18:10 +0200
  Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories Saravana Kannan <skannan@codeaurora.org> - 2015-10-15 21:30 +0200
    Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-15 23:10 +0200
    Re: [PATCH V2 4/5] cpufreq: create cpu/cpufreq/policyX directories Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-16 08:00 +0200

csiph-web