Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h

From	"H. Nikolaus Schaller" <hns@goldelico.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h
Date	2015-10-15 19:20 +0200
Message-ID	<qjUm6-4xd-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <qfBUJ-4pO-1@gated-at.bofh.it> <qjtFf-7cv-11@gated-at.bofh.it> <qjv4m-Wf-7@gated-at.bofh.it> <qjJK4-5GL-27@gated-at.bofh.it> <qjUcp-4l6-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 15.10.2015 um 19:07 schrieb Nathan Lynch <Nathan_Lynch@mentor.com>:

> On 10/15/2015 12:52 AM, H. Nikolaus Schaller wrote:
>> Am 14.10.2015 um 16:16 schrieb Nathan Lynch <nathan_lynch@mentor.com>:
>>> and it would be easier for me to deal with a patch that isn't
>>> whitespace-damaged.
>> 
>> You mean:
>> 
>> ERROR: space prohibited before that close parenthesis ')'
>> #46: FILE: arch/arm/vdso/vdsomunge.c:64:
>> +		(((unsigned short)(x) & (unsigned short)0xff00U) >> 8) ))
>> 
>> ERROR: space prohibited before that close parenthesis ')'
>> #53: FILE: arch/arm/vdso/vdsomunge.c:71:
>> +		(((unsigned int)(x) & (unsigned int)0xff000000UL) >> 24) ))
>> 
>> Well, I had copied that verbatim from arch/mips/boot/elf2ecoff.c and
>> thought that it is better readable, but it is easy to fix.
> 
> That's not what I was referring to, but it is fine to fix that too.
> 
> What I meant was that the first column of the patch body is corrupted.
> Your v2 has hunks like this (bad):
> 
> static Elf32_Word read_elf_word(Elf32_Word word, bool swap)
> {
> -	return swap ? bswap_32(word) : word;
> +	return swap ? swab32(word) : word;
> }
> 
> 
> Your v3 has this (good):
> 
> static void write_elf_word(Elf32_Word val, Elf32_Word *dst, bool swap)
> {
> -	*dst = swap ? bswap_32(val) : val;
> +	*dst = swap ? swab32(val) : val;
> }

Does this mean it is ok now in V3 in all cases? I have switched my patch editor
tool from indirect git imap-send to git send-email (which appears to be more
compatible).

BR and thanks,
Nikolaus Schaller

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-14 14:50 +0200
  Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific  byteswap.h Nathan Lynch <Nathan_Lynch@mentor.com> - 2015-10-14 16:20 +0200
    Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-15 08:00 +0200
      Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific  byteswap.h Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-15 18:40 +0200
        Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-15 19:00 +0200
      Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific  byteswap.h Nathan Lynch <Nathan_Lynch@mentor.com> - 2015-10-15 19:10 +0200
        Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-15 19:20 +0200
          Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific  byteswap.h Nathan Lynch <Nathan_Lynch@mentor.com> - 2015-10-15 19:30 +0200

csiph-web