Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1247958
| From | Liviu Dudau <Liviu.Dudau@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RFC PATCH 0/4] drm: Cleanup probe function for component based masters. |
| Date | 2015-10-15 18:20 +0200 |
| Message-ID | <qjTq2-3aG-29@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
A few drivers in drivers/gpu/drm are component-enabled and use quite similar code sequences to probe for their encoder slaves at the remote end of the ports. Move the code into a "generic" function and remove it from the drivers. The end results is that drivers get a reference count fix (imx), more thorough error checking (imx again), setting the DMA coherent mask (armada) plus a decrease in the overall count of LoC. I'm looking for comments and testing of the patchset (only compile tested from my end as I don't have access to all the devices touched by the changes). My main interest is in finding out if -EINVAL is the correct code to return if dev->of_node == NULL (handy now, as it is different from the other possible error codes and used in armada to trigger old platform_data support. Also looking for thoughts on the correctness of the patch and if it possible to co-opt more drivers into using the function. Best regards, Liviu Liviu Dudau (4): drm: Introduce generic probe function for component based masters. drm/imx: Convert the probe function to the generic drm_of_component_probe() drm/rockchip: Convert the probe function to the generic drm_of_component_probe() drm/armada: Convert the probe function to the generic drm_of_component_probe() drivers/gpu/drm/armada/armada_drv.c | 83 +++++++++----------------- drivers/gpu/drm/drm_of.c | 92 +++++++++++++++++++++++++++++ drivers/gpu/drm/imx/imx-drm-core.c | 54 +---------------- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 84 ++------------------------ include/drm/drm_of.h | 12 ++++ 5 files changed, 138 insertions(+), 187 deletions(-) -- 2.6.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[RFC PATCH 0/4] drm: Cleanup probe function for component based masters. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-15 18:20 +0200 [RFC PATCH 1/4] drm: Introduce generic probe function for component based masters. Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-15 18:20 +0200 [RFC PATCH 3/4] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-15 18:20 +0200 [RFC PATCH 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe() Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-15 18:20 +0200
csiph-web