Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN
Date	2015-10-15 12:00 +0200
Message-ID	<qjNui-2M8-15@gated-at.bofh.it> (permalink)
References	<qjNui-2M8-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Oct 14, 2015 at 06:14:16PM -0500, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling
> ECC_CORR_EN, when error happens, it is the user's responsibility to perform
> a full SDRAM scrub.
> 
> Remove the check for ECC_CORR_EN.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
>  drivers/edac/altera_edac.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
> index 7b64dc7..7a52585 100644
> --- a/drivers/edac/altera_edac.h
> +++ b/drivers/edac/altera_edac.h
> @@ -30,8 +30,7 @@
>  #define CV_CTLCFG_GEN_SB_ERR       0x2000
>  #define CV_CTLCFG_GEN_DB_ERR       0x4000
>  
> -#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN | \
> -				   CV_CTLCFG_ECC_CORR_EN)
> +#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN)
>  
>  /* SDRAM Controller Address Width Register */
>  #define CV_DRAMADDRW_OFST          0x2C
> -- 

Applied,
thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for  ECC_CORR_EN Borislav Petkov <bp@alien8.de> - 2015-10-15 12:00 +0200

csiph-web