Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1247571
| From | Marc Dietrich <marvin24@gmx.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: nvec: fixed few coding style warnings |
| Date | 2015-10-15 10:50 +0200 |
| Message-ID | <qjMox-1d8-7@gated-at.bofh.it> (permalink) |
| References | <qjuUG-KS-29@gated-at.bofh.it> <qjyOD-6ut-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Am Mittwoch, 14. Oktober 2015, 21:12:36 schrieb Dan Carpenter:
> On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote:
> > Fixed allignmnet issues and block comments usage
>
> Split it apart by type of fix.
>
> > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> >
> > } else {
> >
> > nvec->rx = nvec_msg_alloc(nvec, NVEC_MSG_RX);
> > /* Should not happen in a normal world */
> >
> > - if (unlikely(nvec->rx == NULL)) {
> > + if (!unlikely(nvec->rx)) {
>
> This isn't right. You intented to say:
>
> if (unlikely(!nvec->rx)) {
>
> But even better to just remove the unlikely entirely.
>
> if (!nvec->rx) {
why? the "unlikely" is there to optimize a critical interrupt path.
Marc
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: nvec: fixed few coding style warnings Sakshi Bansal <sakshi.april5@gmail.com> - 2015-10-14 16:10 +0200
Re: [PATCH] staging: nvec: fixed few coding style warnings Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-14 20:20 +0200
Re: [PATCH] staging: nvec: fixed few coding style warnings Marc Dietrich <marvin24@gmx.de> - 2015-10-15 10:50 +0200
Re: [PATCH] staging: nvec: fixed few coding style warnings Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-15 10:50 +0200
Re: [PATCH] staging: nvec: fixed few coding style warnings Marc Dietrich <marvin24@gmx.de> - 2015-10-15 11:20 +0200
csiph-web