Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247559

Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs

Show all headers | View raw

Stephen,

On Wed, 14 Oct 2015 11:21:38 -0700, Stephen Boyd wrote:

> How about this patch?
> 
> ---8<----
> diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
> index 5837eb8a212f..85da8b983256 100644
> --- a/drivers/clk/mvebu/clk-cpu.c
> +++ b/drivers/clk/mvebu/clk-cpu.c
> @@ -197,6 +197,7 @@ static void __init of_cpu_clk_setup(struct device_node *node)
>  	for_each_node_by_type(dn, "cpu") {
>  		struct clk_init_data init;
>  		struct clk *clk;
> +		struct clk *parent_clk;
>  		char *clk_name = kzalloc(5, GFP_KERNEL);
>  		int cpu, err;
>  
> @@ -208,8 +209,9 @@ static void __init of_cpu_clk_setup(struct device_node *node)
>  			goto bail_out;
>  
>  		sprintf(clk_name, "cpu%d", cpu);
> +		parent_clk = of_clk_get(node, 0);
>  
> -		cpuclk[cpu].parent_name = of_clk_get_parent_name(node, 0);
> +		cpuclk[cpu].parent_name = __clk_get_name(parent_clk);
>  		cpuclk[cpu].clk_name = clk_name;
>  		cpuclk[cpu].cpu = cpu;
>  		cpuclk[cpu].reg_base = clock_complex_base;

Applied on top of 4.3-rc5, this patch fixes the problem for me, without
any change to the Device Tree files.

It's probably the easiest option for 4.3. Do you want me to submit a
patch, or will you apply it directly to your clk tree?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-14 17:10 +0200
  Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Stephen Boyd <sboyd@codeaurora.org> - 2015-10-14 20:30 +0200
    Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-14 22:20 +0200
      Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Stephen Boyd <sboyd@codeaurora.org> - 2015-10-14 23:10 +0200
        Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-15 10:50 +0200
          Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Stephen Boyd <sboyd@codeaurora.org> - 2015-10-15 20:10 +0200
            Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-15 22:00 +0200
              [PATCH] clk: Make of_clk_get_parent_name() robust with #clock-cells = 1 Stephen Boyd <sboyd@codeaurora.org> - 2015-10-16 01:30 +0200
                Re: [PATCH] clk: Make of_clk_get_parent_name() robust with #clock-cells = 1 Michael Turquette <mturquette@baylibre.com> - 2015-10-16 15:00 +0200
                Re: [PATCH] clk: Make of_clk_get_parent_name() robust with  #clock-cells = 1 Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-16 15:10 +0200
    Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-15 10:30 +0200
      Re: [PATCH 14/26] clk: mvebu: Convert to clk_hw based provider APIs Stephen Boyd <sboyd@codeaurora.org> - 2015-10-15 20:10 +0200

csiph-web