Re: [PATCH v4 09/11] smack: namespace groundwork

From	"Hillf Danton" <hillf.zj@alibaba-inc.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 09/11] smack: namespace groundwork
Date	2015-10-15 09:50 +0200
Message-ID	<qjLsu-8id-13@gated-at.bofh.it> (permalink)
References	<qjLsu-8id-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> 
> +static inline void smack_userns_free(struct user_namespace *ns)
> +{
> +	struct smack_ns *snsp = ns->security;
> +	struct smack_known *skp;
> +	struct smack_known_ns *sknp, *n;
> +
> +	list_for_each_entry_safe(sknp, n, &snsp->smk_mapped, smk_list_ns) {
> +		skp = sknp->smk_unmapped;
> +
> +		mutex_lock(&skp->smk_mapped_lock);
> +		list_del_rcu(&sknp->smk_list_known);
> +		if (sknp->smk_allocated)
> +			kfree(sknp->smk_mapped);
> +		kfree(sknp);

sknp is released,
> +		mutex_unlock(&skp->smk_mapped_lock);
> +
> +		list_del(&sknp->smk_list_ns);

but it is used again! typo?
> +	}
> +
> +	kfree(snsp);
> +}
> +
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 09/11] smack: namespace groundwork "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2015-10-15 09:50 +0200
  Re: [PATCH v4 09/11] smack: namespace groundwork Lukasz Pawelczyk <l.pawelczyk@samsung.com> - 2015-10-15 14:50 +0200
    Re: [PATCH v4 09/11] smack: namespace groundwork Lukasz Pawelczyk <l.pawelczyk@samsung.com> - 2015-10-15 15:00 +0200
      Re: [PATCH v4 09/11] smack: namespace groundwork "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2015-10-16 05:20 +0200
        Re: [PATCH v4 09/11] smack: namespace groundwork Lukasz Pawelczyk <l.pawelczyk@samsung.com> - 2015-10-16 12:20 +0200

csiph-web