Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247343

Re: [PATCH] zsmalloc: don't test shrinker_enabled in zs_shrinker_count()

Show all headers | View raw

On Wed, Oct 14, 2015 at 10:57:59AM +0900, Sergey Senozhatsky wrote:
> We don't let user to disable shrinker in zsmalloc (once
> it's been enabled), so no need to check ->shrinker_enabled
> in zs_shrinker_count(), at the moment at least.

I'm in favor of removing shrinker disable feature with this patch(
although we didn't implement it yet) because if there is some problem
of compaction, we should reveal and fix it without hiding with the
feature.

One thing I want is if we decide it, let's remove all things
about shrinker_enabled(ie, variable).
If we might need it later, we could introduce it easily.

Thanks.

> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
>  mm/zsmalloc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 7ad5e54..8ba247d 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1822,9 +1822,6 @@ static unsigned long zs_shrinker_count(struct shrinker *shrinker,
>  	struct zs_pool *pool = container_of(shrinker, struct zs_pool,
>  			shrinker);
>  
> -	if (!pool->shrinker_enabled)
> -		return 0;
> -
>  	for (i = zs_size_classes - 1; i >= 0; i--) {
>  		class = pool->size_class[i];
>  		if (!class)
> -- 
> 2.6.1.134.g4b1fd35
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] zsmalloc: don't test shrinker_enabled in zs_shrinker_count() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-10-14 04:00 +0200
  Re: [PATCH] zsmalloc: don't test shrinker_enabled in  zs_shrinker_count() Minchan Kim <minchan@kernel.org> - 2015-10-15 04:30 +0200
    Re: [PATCH] zsmalloc: don't test shrinker_enabled in  zs_shrinker_count() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-10-15 06:00 +0200
      Re: [PATCH] zsmalloc: don't test shrinker_enabled in  zs_shrinker_count() Minchan Kim <minchan@kernel.org> - 2015-10-15 12:40 +0200

csiph-web