Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247287

Re: [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote:
> This removes the reducant error path and now no longer used goto
> label  err_sw_init after the call to ixgb_probe in the function
> ixgb_sw_init after calling this function due to it always returning
> zero as it is guarantee to run successfully without any issues.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/net/ethernet/intel/ixgb/ixgb_main.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

This driver (ixgb), as well as e100 and e1000 are in maintenance mode
which means bug fixes ONLY!

Is this patch necessary?  Answer: No
Is this a bug fix?  Answer: No
Should you have sent this patch?  See answers to previous questions.

Please ask these questions to yourself when putting together a patch
against these drivers (listed above).

With that said, dropping this series.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH RESEND 1/2] ixgb:Remove reducant error path after call  to ixgb_sw_init in the function ixgb_probe Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2015-10-15 03:30 +0200

csiph-web