Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247290

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

Show all headers | View raw

On Oct. Thursday 15 (42) 12:46 AM, Andrew Lunn wrote:
> On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote:
> > DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event in
> > order to configure the VLAN map of every port.
> > 
> > This VLAN map is a feature of these switch chips to hardcode and restrict which
> > output ports a given input port can egress frames to.
> > 
> > A Linux bridge is a simple untagged VLAN propagated by the bridge code itself.
> > With a proper 802.1Q support, a driver does not need this hook anymore, and
> > will simply program the related VLAN object.
> > 
> > This patchset improves the hardware bridging code in the mv88e6xxx driver with
> > a strict 802.1Q mode.
> 
> Hi Vivien
> 
> I just tested this as part of net-next/master, and found a problem....
> 
> If i do:
> 
> ip link set lan0 up
> ip addr add 192.168.10.2/24 dev lan0
> 
> It will not ping. Looking in sys/kernel/debug/dsa0/stats i see
> broadcast packets, probably ARP, being received at the port.
> But they are not being forwarded out the CPU port.
> 
> If however i do
> 
> brctl addbr br0
> brctl addif br0 lan0
> ip addr add 192.168.10.2/24 dev br0
> ip link set br0 up
> 
> i can ping.
> 
> So it looks like we are too restrictive by default. You should be able
> to use interfaces as they are, without a bridge.

Correct, if the ports are not in a VLAN by default, they cannot talk.

If you want to, I think the special VLAN 0 can be used for that purpose.
IIRC, in a given configuration, Linux add the interfaces (thus programs
the hardware) with VLAN 0. I'm not sure when, maybe when the
.ndo_vlan_rx_add_vid is implemented, I need to give it a shot.

Otherwise, I can send you a patch configuring the VLAN 0 on switch
setup if this is the behavior we want.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-12 00:10 +0200
  [PATCH net-next 3/4] net: dsa: do not warn unsupported bridge ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-12 00:20 +0200
  [PATCH net-next 1/4] net: dsa: mv88e6xxx: bridges do not need an FID Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-12 00:20 +0200
  Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging David Miller <davem@davemloft.net> - 2015-10-13 13:20 +0200
  Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Andrew Lunn <andrew@lunn.ch> - 2015-10-15 00:50 +0200
    Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-15 03:40 +0200
      Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Florian Fainelli <f.fainelli@gmail.com> - 2015-10-15 03:50 +0200
        Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-15 14:50 +0200
      Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Andrew Lunn <andrew@lunn.ch> - 2015-10-15 05:00 +0200
        Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Guenter Roeck <linux@roeck-us.net> - 2015-10-15 05:20 +0200
        Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-15 15:00 +0200

csiph-web