[PATCH 2/2] sd: skip reclaiming host on mmc_add_card() error

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] sd: skip reclaiming host on mmc_add_card() error
Date	2015-10-14 23:00 +0200
Message-ID	<qjBjs-1yI-13@gated-at.bofh.it> (permalink)
Organization	Cogent Embedded Inc.

Show all headers | View raw

There's little sense in releasing the host on mmc_add_card() error
immediately after reclaiming  it, so  reclaim the host  only in case
of success.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch.

 drivers/mmc/core/sd.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: mmc/drivers/mmc/core/sd.c
===================================================================
--- mmc.orig/drivers/mmc/core/sd.c
+++ mmc/drivers/mmc/core/sd.c
@@ -1243,14 +1243,13 @@ int mmc_attach_sd(struct mmc_host *host)
 
 	mmc_release_host(host);
 	err = mmc_add_card(host->card);
-	mmc_claim_host(host);
 	if (err)
 		goto remove_card;
 
+	mmc_claim_host(host);
 	return 0;
 
 remove_card:
-	mmc_release_host(host);
 	mmc_remove_card(host->card);
 	host->card = NULL;
 	mmc_claim_host(host);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/2] sd: skip reclaiming host on mmc_add_card() error Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-14 23:00 +0200

csiph-web