Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1245752

Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static

From Kishon Vijay Abraham I <kishon@ti.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static
Date 2015-10-13 16:10 +0200
Message-ID <qj8r8-ok-19@gated-at.bofh.it> (permalink)
References <qeJUl-2dw-3@gated-at.bofh.it> <qeJUl-2dw-1@gated-at.bofh.it> <qj6fD-5t6-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

On Tuesday 13 October 2015 05:08 PM, Alim Akhtar wrote:
> HI
> How I am support to handle this patch? Should I just fix these warnings
> in my patch or I just add this as a separate patch on the top of the
> series?

This series has not been merged yet. So you can fix this patch.

Thanks
Kishon
> 
> 
> On 10/01/2015 04:34 PM, kbuild test robot wrote:
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>   phy-exynos-ufs.c |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/phy-exynos-ufs.c b/drivers/phy/phy-exynos-ufs.c
>> index 343fcaf..835ee78 100644
>> --- a/drivers/phy/phy-exynos-ufs.c
>> +++ b/drivers/phy/phy-exynos-ufs.c
>> @@ -66,7 +66,7 @@ static bool match_cfg_to_pwr_mode(u8 desc, u8
>> required_pwr)
>>       return false;
>>   }
>>
>> -int exynos_ufs_phy_calibrate(struct phy *phy, enum phy_cfg_tag tag,
>> u8 pwr)
>> +static int exynos_ufs_phy_calibrate(struct phy *phy, enum phy_cfg_tag
>> tag, u8 pwr)
>>   {
>>       struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy);
>>       struct exynos_ufs_phy_cfg **cfgs = ufs_phy->cfg;
>> @@ -93,14 +93,14 @@ out:
>>       return 0;
>>   }
>>
>> -void exynos_ufs_phy_set_lane_cnt(struct phy *phy, u8 lane_cnt)
>> +static void exynos_ufs_phy_set_lane_cnt(struct phy *phy, u8 lane_cnt)
>>   {
>>       struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy);
>>
>>       ufs_phy->lane_cnt = lane_cnt;
>>   }
>>
>> -int exynos_ufs_phy_wait_for_lock_acq(struct phy *phy)
>> +static int exynos_ufs_phy_wait_for_lock_acq(struct phy *phy)
>>   {
>>       struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy);
>>       const unsigned int timeout_us = 100000;
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be  static Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-13 13:50 +0200
  Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be  static Kishon Vijay Abraham I <kishon@ti.com> - 2015-10-13 16:10 +0200
  Re: [kbuild-all] [RFC PATCH] phy: exynos-ufs:  exynos_ufs_phy_calibrate() can be static Fengguang Wu <lkp@intel.com> - 2015-10-13 16:40 +0200

csiph-web