Re: [RFC v2 PATCH 06/14] irq: add struct ipi_mapping and its helper functions

From	Qais Yousef <qais.yousef@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 PATCH 06/14] irq: add struct ipi_mapping and its helper functions
Date	2015-10-13 16:40 +0200
Message-ID	<qj8Ub-Wq-25@gated-at.bofh.it> (permalink)
References	<qj4Qx-3vO-3@gated-at.bofh.it> <qj4QA-3vO-35@gated-at.bofh.it> <qj7Y6-819-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/13/2015 02:31 PM, Thomas Gleixner wrote:
> On Tue, 13 Oct 2015, Qais Yousef wrote:
>
> +
> +int irq_unmap_ipi(struct ipi_mapping *map,
> +		  unsigned int cpu, irq_hw_number_t *hwirq)
> +{
> +	if (cpu >= map->nr_cpus)
> +		return -EINVAL;
> +
> +	if (map->cpumap[cpu] == INVALID_HWIRQ)
> +		return -EINVAL;
> +
> +	if (hwirq)
> +		*hwirq = map->cpumap[cpu];
> Why do we store hwirq in unmap?

So that the irqchip driver can return the hwirq to its available IPI pool.

>
> All these new functions lack kerneldoc comments.

Apologies about the missing docs here and in other places.

Thanks,
Qais
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v2 PATCH 06/14] irq: add struct ipi_mapping and its helper functions Qais Yousef <qais.yousef@imgtec.com> - 2015-10-13 12:20 +0200
  Re: [RFC v2 PATCH 06/14] irq: add struct ipi_mapping and its helper  functions Thomas Gleixner <tglx@linutronix.de> - 2015-10-13 15:40 +0200
    Re: [RFC v2 PATCH 06/14] irq: add struct ipi_mapping and its helper  functions Qais Yousef <qais.yousef@imgtec.com> - 2015-10-13 16:40 +0200

csiph-web