Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1245655

[char-misc-next 1/5] mei: cancel driver workers only after client devices were removed

From Tomas Winkler <tomas.winkler@intel.com>
Newsgroups linux.kernel
Subject [char-misc-next 1/5] mei: cancel driver workers only after client devices were removed
Date 2015-10-13 14:10 +0200
Message-ID <qj6yZ-66w-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


In process of client devices removal from the bus there still
might be communication between a driver and the mei device
hence we need to cancel supporting workers only after all
the client devices were removed.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 drivers/misc/mei/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
index e374661652cd..3edafc8d3ad4 100644
--- a/drivers/misc/mei/init.c
+++ b/drivers/misc/mei/init.c
@@ -329,10 +329,10 @@ void mei_stop(struct mei_device *dev)
 {
 	dev_dbg(dev->dev, "stopping the device.\n");
 
-	mei_cancel_work(dev);
-
 	mei_cl_bus_remove_devices(dev);
 
+	mei_cancel_work(dev);
+
 	mutex_lock(&dev->device_lock);
 
 	mei_wd_stop(dev);
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[char-misc-next 1/5] mei: cancel driver workers only after client devices were removed Tomas Winkler <tomas.winkler@intel.com> - 2015-10-13 14:10 +0200
  [char-misc-next 4/5] mei: bus: fix c&p issue in the kdoc Tomas Winkler <tomas.winkler@intel.com> - 2015-10-13 14:10 +0200
  [char-misc-next 5/5] mei: amthif: Do not compare bool to 0/1 Tomas Winkler <tomas.winkler@intel.com> - 2015-10-13 14:10 +0200
  [char-misc-next 3/5] mei: fix the KDoc formating Tomas Winkler <tomas.winkler@intel.com> - 2015-10-13 14:10 +0200

csiph-web