Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration
Date	2015-10-13 14:20 +0200
Message-ID	<qj6IF-6iL-5@gated-at.bofh.it> (permalink)
References	<qiN3k-2LY-27@gated-at.bofh.it> <qiNd0-2Xu-27@gated-at.bofh.it> <qj44e-2jZ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 13 October 2015 10:16:55 John Garry wrote:
> 
> >
> >> +       sha = SHOST_TO_SAS_HA(shost) = &hisi_hba->sha;
> >> +       platform_set_drvdata(pdev, sha);
> >> +
> >> +       phy_nr = port_nr = HISI_SAS_MAX_PHYS;
> >> +
> >> +       arr_phy = devm_kcalloc(dev, phy_nr, sizeof(void *), GFP_KERNEL);
> >> +       arr_port = devm_kcalloc(dev, port_nr, sizeof(void *), GFP_KERNEL);
> >> +       if (!arr_phy || !arr_port)
> >> +               return -ENOMEM;
> >
> > And since these are fixed-size arrays, they can be moved in there as well.
> >
> In a later patch we set as follows:
> phy_nr = port_nr = hisi_hba->n_phy;
> 
> You did say in our earlier private review that we could add statically 
> to hba strcut, but I commented that other vendors do similar so I would 
> wait for more input.

Ok, I forgot about that.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration Arnd Bergmann <arnd@arndb.de> - 2015-10-12 17:30 +0200
  Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration John Garry <john.garry@huawei.com> - 2015-10-13 11:30 +0200
    Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration Arnd Bergmann <arnd@arndb.de> - 2015-10-13 14:20 +0200

csiph-web