Re: [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file

From	Peter Griffin <peter.griffin@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file
Date	2015-10-13 12:50 +0200
Message-ID	<qj5jA-45m-17@gated-at.bofh.it> (permalink)
References	<q7xlf-42z-3@gated-at.bofh.it> <q7xlg-42z-37@gated-at.bofh.it> <qhlCb-7Qf-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Thu, 08 Oct 2015, Koul, Vinod wrote:

> On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote:
> 
> > +#define FDMA_ID_OFST		0x00000
> > +#define FDMA_VER_OFST		0x00004
> > > +
> > +#define FDMA_EN_OFST		0x00008
> 
> Why cant these be BIT() to maintain consistency?
> 

These are actually register offsets. I'm only using the BIT
macro for bitfields within the registers e.g. FDMA_EN_RUN

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/9] dmaengine: st_fdma:  Add STMicroelectronics FDMA  driver header file "Koul, Vinod" <vinod.koul@intel.com> - 2015-10-08 17:50 +0200
  Re: [PATCH v2 3/9] dmaengine: st_fdma:  Add STMicroelectronics FDMA  driver header file Peter Griffin <peter.griffin@linaro.org> - 2015-10-13 12:50 +0200

csiph-web