Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245469

Re: [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove

Show all headers | View raw

On 2015/10/13 15:41, Borislav Petkov wrote:
> On Tue, Oct 13, 2015 at 10:22:51AM +0800, Tan Xiaojun wrote:
>> debugfs_remove is used to remove a file or an empty directory from
>> the debugfs filesystem, but mci->debugfs is not empty.
> 
> How exactly do you trigger this? And by "this" I'm not even sure what
> the problem is as your commit message doesn't say. So please explain
> also what the problem is.
> 
> Also, use this branch instead:
> 
> http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
> 
> We did change EDAC debugfs handling recently so your patch doesn't apply
> anymore.
> 
> Thanks.
> 

Sorry, I don't describe it well. I do test like that:
1)open EDAC config and open CONFIG_EDAC_DEBUG
2)insmod a edac_mc module (like i3000_edac or others in drivers/edac/)
3)rmmod this module
4)we can also see files under /sys/kernel/debug/edac/ like "fake_inject"

If you think this patch is OK, I will do patch in your branch and send V2.

Thanks.
Xiaojun


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove Tan Xiaojun <tanxiaojun@huawei.com> - 2015-10-13 04:20 +0200
  Re: [PATCH] EDAC: use debugfs_remove_recursive instead of  debugfs_remove Borislav Petkov <bp@alien8.de> - 2015-10-13 10:10 +0200
    Re: [PATCH] EDAC: use debugfs_remove_recursive instead of  debugfs_remove Tan Xiaojun <tanxiaojun@huawei.com> - 2015-10-13 10:50 +0200
      Re: [PATCH] EDAC: use debugfs_remove_recursive instead of  debugfs_remove Borislav Petkov <bp@alien8.de> - 2015-10-13 12:10 +0200

csiph-web