Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

From	Ingi Kim <ingi2.kim@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device
Date	2015-10-13 10:10 +0200
Message-ID	<qj2OL-A2-29@gated-at.bofh.it> (permalink)
References	<qiLbb-8t3-3@gated-at.bofh.it> <qiLbb-8t3-1@gated-at.bofh.it> <qj1SG-7Dx-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Lee Jones,

Okay, I'm try to remove needless part and resend it
Thanks for the review

Thank you

On 2015년 10월 13일 16:06, Lee Jones wrote:
> On Mon, 12 Oct 2015, Ingi Kim wrote:
> 
>> This patch adds rt5033-led sub device to support it.
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
>> ---
>>  drivers/mfd/rt5033.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
>> index d60f916..b7f374b 100644
>> --- a/drivers/mfd/rt5033.c
>> +++ b/drivers/mfd/rt5033.c
>> @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
>>  };
>>  
>>  static const struct mfd_cell rt5033_devs[] = {
>> -	{ .name = "rt5033-regulator", },
>>  	{
>> +		.name = "rt5033-regulator",
>> +	}, {
> 
> There's no need for this change.  Please remove it.
> 
>>  		.name = "rt5033-charger",
>>  		.of_compatible = "richtek,rt5033-charger",
>>  	}, {
>>  		.name = "rt5033-battery",
>>  		.of_compatible = "richtek,rt5033-battery",
>> +	}, {
>> +		.name = "rt5033-led",
>> +		.of_compatible = "richtek,rt5033-led",
> 
> For when you resubmit with the hunk above removed:
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>
> 
>>  	},
>>  };
>>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device Ingi Kim <ingi2.kim@samsung.com> - 2015-10-12 15:20 +0200
  Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device Lee Jones <lee.jones@linaro.org> - 2015-10-13 09:10 +0200
    Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device Ingi Kim <ingi2.kim@samsung.com> - 2015-10-13 10:10 +0200

csiph-web