Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245386

RE: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05

From Gabriele Paoloni <gabriele.paoloni@huawei.com>
Newsgroups linux.kernel
Subject RE: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05
Date 2015-10-13 09:00 +0200
Message-ID <qj1IZ-7bO-5@gated-at.bofh.it> (permalink)
References <qhSop-4sE-3@gated-at.bofh.it> <qhSop-4sE-5@gated-at.bofh.it> <qiSZ4-2WA-17@gated-at.bofh.it> <qj1pE-6O2-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> >> +
> >> +static int __init hisi_pcie_init(void)
> >> +{
> >> +	return platform_driver_probe(&hisi_pcie_driver, hisi_pcie_probe);
> >> +}
> >> +subsys_initcall(hisi_pcie_init);
> >
> > Can you use module_platform_driver() or module_platform_driver_probe()
> > here instead of the subsys_initcall()?  No, I don't really know what
> > the difference between module_platform_driver() and
> > module_platform_driver_probe() is, sorry :)
> 
> In fact, I used module_platform_driver_probe in previous version, but
> A PCIe VGA card of HiSilicon will use Hip05 PCIe host, so we modified
> module_platform_driver_probe to subsys_initcall which will be called
> before module_platform_driver_probe.
> 
> We will upstream the driver of above PCIe VGA card soon.
> 
> Many thanks for your reviewing,
> Zhou

Hi Bjorn, firstly many thanks for looking at this.

About this last bit the reason why we use subsys_initcall() is that
our host bridge is embedded in the SoC and as such is not hot-pluggable
for instance see:
http://lxr.free-electrons.com/source/Documentation/driver-model/platform.txt#L59

Our approach is also used by Exynos:
http://lxr.free-electrons.com/source/drivers/pci/host/pci-exynos.c#L644

Cheers

Gab

> 
> >
> > Bjorn
> >
> > .
> >
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Zhou Wang <wangzhou1@hisilicon.com> - 2015-10-10 04:50 +0200
  Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Bjorn Helgaas <helgaas@kernel.org> - 2015-10-12 23:40 +0200
    Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Zhou Wang <wangzhou1@hisilicon.com> - 2015-10-13 08:40 +0200
      RE: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2015-10-13 09:00 +0200
        Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Arnd Bergmann <arnd@arndb.de> - 2015-10-13 13:20 +0200
          RE: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2015-10-14 10:40 +0200
            Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Arnd Bergmann <arnd@arndb.de> - 2015-10-14 11:10 +0200
              RE: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2015-10-14 11:40 +0200
                Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Arnd Bergmann <arnd@arndb.de> - 2015-10-14 11:50 +0200
                RE: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2015-10-14 12:00 +0200
    Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Arnd Bergmann <arnd@arndb.de> - 2015-10-13 13:20 +0200
      RE: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Gabriele Paoloni <gabriele.paoloni@huawei.com> - 2015-10-13 17:00 +0200
        Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Arnd Bergmann <arnd@arndb.de> - 2015-10-13 17:10 +0200
          Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Arnd Bergmann <arnd@arndb.de> - 2015-10-14 11:10 +0200
            Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Zhou Wang <wangzhou1@hisilicon.com> - 2015-10-14 11:50 +0200
              Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05 Arnd Bergmann <arnd@arndb.de> - 2015-10-15 00:00 +0200
                Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Zhou Wang <wangzhou1@hisilicon.com> - 2015-10-15 10:40 +0200
          Re: [PATCH v10 4/6] PCI: hisi: Add PCIe host support for HiSilicon  SoC Hip05 Zhou Wang <wangzhou1@hisilicon.com> - 2015-10-14 11:10 +0200

csiph-web