Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244278

[PATCH 0/2] irqchip: make non-modular code explicitly non-modular

Show all headers | View raw

In a previous merge window, we made changes to allow better
delineation between modular and non-modular code in commit
0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init
from init.h to module.h").  This allows us to now ensure module code
looks modular and non-modular code does not accidentally look modular
just to avoid suffering build breakage.

Here we target code that is, by nature of their Makefile and/or
Kconfig settings, only available to be built-in, but implicitly
presenting itself as being possibly modular by way of using modular
headers, macros, and functions.

The goal here is to remove that illusion of modularity from these
files, but in a way that leaves the actual runtime unchanged.
In doing so, we remove code that has never been tested and adds
no value to the tree.  And we continue the process of expecting a
level of consistency between the Kconfig/Makefile of code and the
code in use itself.

Fortuntately the irqchip subsystem has just two instances.  For
comparison there are over 300 instances tree wide, resulting in a
possible net removal of on the order of 5000 lines of unused code.

Build tested on the latest linux-next, on ARM.

Paul.
--

Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Magnus Damm <damm+renesas@opensource.se>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>

Paul Gortmaker (2):
  drivers/irqchip: make irq-renesas-intc-irqpin.c explicitly non-modular
  drivers/irqchip: make irq-renesas-irqc.c explicitly non-modular

 drivers/irqchip/irq-renesas-intc-irqpin.c | 24 +-----------------------
 drivers/irqchip/irq-renesas-irqc.c        | 30 +-----------------------------
 2 files changed, 2 insertions(+), 52 deletions(-)

-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] irqchip: make non-modular code explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-10-12 01:10 +0200
  Re: [PATCH 0/2] irqchip: make non-modular code explicitly non-modular Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-12 09:10 +0200
    Re: [PATCH 0/2] irqchip: make non-modular code explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-10-14 04:30 +0200

csiph-web