Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values
Date	Mon, 12 Oct 2015 00:20:02 +0200
Message-ID	<qix8d-4PI-1@gated-at.bofh.it> (permalink)
References	<qiwvw-3Qd-15@gated-at.bofh.it>
X-Original-To	Ben Cartwright-Cox <ben@benjojo.co.uk>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=RAOtbGjvKSOQ4uSRKNyBkfG/AWqTry9vCZ4j0REWy9M=; b=J42bGVu831HXpp+8lB2W2Y59NEDOqwCvyvg0fFYKf/ymBPAG93oPV/4qVkeMX5PTBv wBQpPAXAXEMOuzulz5KA1rDJxdyfEjF9GnbV+IdLn51t10rI4aUeS8BLak1GLJHH5tXI NWoRIzXUR8jGQB/ep/HowWwRnXFWcBYNXHqc54khw0ssBgNUVkn1ZhkHBGfy5ATplP+B 5Lggmg5bSVUmD4m+fHBemYRFbNmSNgaQJXgbuMaJwBechlOqvqFKv4Doq7GeVYKOCtai on9GLcXdVw6lHNp5xksSOAL6o6CbY4zZ1TD4i6xrRwWPwGlZZyTvSvSeQ0JrMdjVAYAp 5gUw==
X-Received	by 10.66.219.162 with SMTP id pp2mr30633388pac.59.1444601450901; Sun, 11 Oct 2015 15:10:50 -0700 (PDT)
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.10.4-0ubuntu2
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ben+patches@benjojo.co.uk, David L Stevens <dlstevens@us.ibm.com>
X-Original-Date	Sun, 11 Oct 2015 15:10:48 -0700
X-Original-Message-ID	<1444601448.27760.143.camel@edumazet-glaptop2.roam.corp.google.com>
X-Original-References	<20151011205528.GA4322@benjojo.co.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1244239

Show key headers only | View raw

On Sun, 2015-10-11 at 20:55 +0000, Ben Cartwright-Cox wrote:
> Sending ICMP packets with raw sockets ends up in the SNMP counters
> logging the type as the first byte of the IPv4 header rather than
> the ICMP header (in nearly all cases this is seen as "OutType69".
> This is fixed by adding the IP Header Length to the casting into
> a icmphdr struct.
> 
> Signed-off-by: Ben Cartwright-Cox <ben@benjojo.co.uk>
> ---
>  net/ipv4/raw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
> index 561cd4b..1ad8bae 100644
> --- a/net/ipv4/raw.c
> +++ b/net/ipv4/raw.c
> @@ -409,7 +409,7 @@ static int raw_send_hdrinc(struct sock *sk, struct flowi4 *fl4,
>  	}
>  	if (iph->protocol == IPPROTO_ICMP)
>  		icmp_out_count(net, ((struct icmphdr *)
> -			skb_transport_header(skb))->type);
> +			skb_transport_header(skb) + iphlen)->type);
>  
>  	err = NF_HOOK(NFPROTO_IPV4, NF_INET_LOCAL_OUT, sk, skb,
>  		      NULL, rt->dst.dev, dst_output_sk);


Hmm... This seems to lack checks against a malicious user ?

The only guarantee you have here is that iphlen < length.

It is not enough.

Make sure you do not access not initialized memory or even non existent
one.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP  counter values Ben Cartwright-Cox <ben@benjojo.co.uk> - 2015-10-11 23:40 +0200
  Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP  SNMP counter values Eric Dumazet <eric.dumazet@gmail.com> - 2015-10-12 00:20 +0200
    Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP  SNMP counter values Ben Cox <ben@benjojo.co.uk> - 2015-10-12 00:20 +0200
      Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP  SNMP counter values Eric Dumazet <eric.dumazet@gmail.com> - 2015-10-12 00:50 +0200
        Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP  SNMP counter values Eric Dumazet <eric.dumazet@gmail.com> - 2015-10-12 00:50 +0200
          Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP  SNMP counter values Eric Dumazet <eric.dumazet@gmail.com> - 2015-10-12 01:20 +0200
            Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP  SNMP counter values Ben Cox <ben@benjojo.co.uk> - 2015-10-12 01:20 +0200
              Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP  SNMP counter values Eric Dumazet <eric.dumazet@gmail.com> - 2015-10-12 01:40 +0200

csiph-web