Re: [PATCH] sched_clock: add data pointer argument to read callback

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched_clock: add data pointer argument to read callback
Date	2015-10-11 22:50 +0200
Message-ID	<qivJ8-2Fs-3@gated-at.bofh.it> (permalink)
References	<qhPgS-8oj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Mans,

On Fri, 9 Oct 2015, Mans Rullgard wrote:

> This passes a data pointer specified in the sched_clock_register()
> call to the read callback allowing simpler implementations thereof.
>
> In this patch, existing uses of this interface are simply updated
> with a null pointer.

I can't see any simplifaction of any driver. This is called in hot
pathes and that extra unused argument just adds register pressure for
no value.

What are you actually trying to solve?

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] sched_clock: add data pointer argument to read  callback Thomas Gleixner <tglx@linutronix.de> - 2015-10-11 22:50 +0200

csiph-web