Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244173

Re: [PATCH 1/1] I have a board it block on i8259A_shutdown when I want to poweroff. It is not always re-produce.

Show all headers | View raw

Figo,

On Sat, 10 Oct 2015, Figo wrote:

Thanks for resending, but let me clarify a few things.

Subject line:

[PATCH 1/1] I have a board it block on i8259A_shutdown when I want to 
          poweroff. It is not always re-produce.

That's not a proper patch subject line. It should start with the
subsystem and the particular unit in the subsystem you are modifying.

[PATCH] x86/i8259:

The subject itself should contain a short and understandable
description of the modification. Something like this:

[PATCH] x86/i8259: Take i8259_lock in i8259A_shutdown()

or 

[PATCH] x86/i8259: Prevent race in i8259A_shutdown()

Ok?

That must be followed by an explanation of the problem and how the
modification of the code solves it.

Ok?

Aside of that I provided you another example of a problem which is not
cured by your patch, but I can't find an answer to that either. I
explicitely asked you for more information.

Please always address the questions a reviewer asks you. If the
questions are not clear to you, feel free to ask for clarification.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] I have a board it block on i8259A_shutdown when I want to poweroff. It is not always re-produce. Figo <tianfei.zhang@intel.com> - 2015-10-10 04:50 +0200
  Re: [PATCH 1/1] I have a board it block on i8259A_shutdown when I  want to poweroff. It is not always re-produce. Thomas Gleixner <tglx@linutronix.de> - 2015-10-11 19:40 +0200

csiph-web