Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244038

Re: [PATCHv4 RESEND] staging: vme_user: provide DMA functionality

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Dmitry,

[auto build test WARNING on driver-core/driver-core-next -- if it's inappropriate base, please ignore]

config: x86_64-randconfig-x010-201541 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/staging/vme/devices/vme_user.c: In function 'vme_user_ioctl.isra.4':
>> drivers/staging/vme/devices/vme_user.c:324:7: warning: 'dest' may be used uninitialized in this function [-Wmaybe-uninitialized]
      ret = vme_dma_list_add(dma_list, src, dest, hw_len);
          ^
   drivers/staging/vme/devices/vme_user.c:296:52: note: 'dest' was declared here
      struct vme_dma_attr *pci_attr, *vme_attr, *src, *dest;
                                                       ^
>> drivers/staging/vme/devices/vme_user.c:324:7: warning: 'src' may be used uninitialized in this function [-Wmaybe-uninitialized]
      ret = vme_dma_list_add(dma_list, src, dest, hw_len);
          ^
   drivers/staging/vme/devices/vme_user.c:296:46: note: 'src' was declared here
      struct vme_dma_attr *pci_attr, *vme_attr, *src, *dest;
                                                 ^

vim +/dest +324 drivers/staging/vme/devices/vme_user.c

   308			if (!pci_attr) {
   309				vme_dma_free_attribute(vme_attr);
   310				return -ENOMEM;
   311			}
   312	
   313			switch (dma_op->dir) {
   314			case VME_DMA_MEM_TO_VME:
   315				src = pci_attr;
   316				dest = vme_attr;
   317				break;
   318			case VME_DMA_VME_TO_MEM:
   319				src = vme_attr;
   320				dest = pci_attr;
   321				break;
   322			}
   323	
 > 324			ret = vme_dma_list_add(dma_list, src, dest, hw_len);
   325	
   326			/*
   327			 * XXX VME API doesn't mention whether we should keep
   328			 * attributes around
   329			 */
   330			vme_dma_free_attribute(vme_attr);
   331			vme_dma_free_attribute(pci_attr);
   332	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv4 RESEND] staging: vme_user: provide DMA functionality Dmitry Kalinkin <dmitry.kalinkin@gmail.com> - 2015-10-11 00:30 +0200
  Re: [PATCHv4 RESEND] staging: vme_user: provide DMA functionality kbuild test robot <lkp@intel.com> - 2015-10-11 02:00 +0200
    [PATCHv5] staging: vme_user: provide DMA functionality Dmitry Kalinkin <dmitry.kalinkin@gmail.com> - 2015-10-11 02:20 +0200
      Re: [PATCHv5] staging: vme_user: provide DMA functionality Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-18 06:00 +0200
        Re: [PATCHv5] staging: vme_user: provide DMA functionality Dmitry Kalinkin <dmitry.kalinkin@gmail.com> - 2015-10-18 06:10 +0200

csiph-web