Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244030

Re: [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl driver

Show all headers | View raw

Hi Jisheng,

On Fri, Oct 09, 2015 at 05:22:38PM +0800, Jisheng Zhang wrote:
> On Fri, 9 Oct 2015 11:03:53 +0200
> Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> > 
> > Finally you can move the OF dependency to the PINCTRL_BERLIN config as
> > all Berlin pinctrl drivers depends on it.
> 
> PINCTRL_BERLIN isn't user visible and it's selected by PINCTRL_BERLIN_BG4CT. So
> we may have the following random config case:
> 
> CONFIG_OF=n
> CONFIG_PINCTRL_BERLIN_BG4CT=y
> 
> In this case, there will be build errors for we missed OF. So we have to
> make PINCTRL_BERLIN_BG4CT depends on OF. What do you think? Or is there
> better solution?

That's true.

But because other Berlin pinctrl drivers also depends on CONFIG_OF, we
need to make then depend on it too. This isn't the topic of this series
so I'll send a separate patch later.

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/6] arm64: berlin: add pinctrl support Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 10:30 +0200
  [PATCH v4 1/6] pinctrl: berlin: introduce berlin_pinctrl_probe_regmap() Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 10:30 +0200
    Re: [PATCH v4 1/6] pinctrl: berlin: introduce  berlin_pinctrl_probe_regmap() Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-10-09 11:10 +0200
  [PATCH v4 3/6] arm64: berlin: add the pinctrl dependency for Marvell Berlin SoCs Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 10:30 +0200
    Re: [PATCH v4 3/6] arm64: berlin: add the pinctrl dependency for  Marvell Berlin SoCs Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-10-09 11:10 +0200
  [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl driver Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 10:30 +0200
    Re: [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-10-09 11:10 +0200
      Re: [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl  driver Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 11:30 +0200
        Re: [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-10-11 00:40 +0200
  [PATCH v4 5/6] arm64: dts: berlin4ct: add the pinctrl node Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 10:30 +0200
    Re: [PATCH v4 5/6] arm64: dts: berlin4ct: add the pinctrl node Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-10-09 11:10 +0200
  [PATCH v4 4/6] pinctrl: dt-binding: document berlin4ct SoC pinctrl Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 10:30 +0200
    Re: [PATCH v4 4/6] pinctrl: dt-binding: document berlin4ct SoC  pinctrl Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-10-09 11:10 +0200

csiph-web