Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245311

Re: [PATCH 1/5] cpufreq: Use cpumask_copy instead of cpumask_or to copy a mask

Show all headers | View raw

On 12-10-15, 12:12, Saravana Kannan wrote:
> >  	if (new_policy) {
> >  		/* related_cpus should at least include policy->cpus. */
> >-		cpumask_or(policy->related_cpus, policy->related_cpus, policy->cpus);
> >+		cpumask_copy(policy->related_cpus, policy->cpus);
> 
> Again, why? It actually seems wrong. A 4 core cluster could come up
> with just 2 cores when the policy is added. But the related CPUs
> would be 4 CPUs.

Firstly, the patch hasn't changed anything at all. related_cpus was
empty until this point, and orring or setting it with ->cpus will
result in the same output.

Secondly, this is what we always wanted. related_cpus should contain
the mask of all possible CPUs for that cluster.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] cpufreq: Use cpumask_copy instead of cpumask_or to copy a mask Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-11 19:30 +0200
  Re: [PATCH 1/5] cpufreq: Use cpumask_copy instead of cpumask_or to  copy a mask Saravana Kannan <skannan@codeaurora.org> - 2015-10-12 21:20 +0200
    Re: [PATCH 1/5] cpufreq: Use cpumask_copy instead of cpumask_or to  copy a mask Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-13 05:30 +0200
      Re: [PATCH 1/5] cpufreq: Use cpumask_copy instead of cpumask_or to  copy a mask Saravana Kannan <skannan@codeaurora.org> - 2015-10-13 21:30 +0200

csiph-web