Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245277

Re: [PATCH v2] HID: hiddev: change hiddev_connect() to return bool

Show all headers | View raw

2015-10-09 22:00 GMT+09:00 Luis de Bethencourt <luisbg@osg.samsung.com>:
> Since hid_connect() only cares about hiddev_connect() succeeding or
> failing, there is no need for this function to return an int and it can
> return a bool instead.

It can return bool but it would not be in line with kernel coding
style. The hiddev_connect() I believe is an action, so "the function
should return an error-code integer.".

Best regards,
Krzysztof

>
> Suggested-by: Jiri Kosina <jikos@kernel.org>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> No idea why my local build did not complain about the obvious mistake
> on the previous version of the patch.
>
> Sorry about that,
> Luis
>
>  drivers/hid/hid-core.c      |  2 +-
>  drivers/hid/usbhid/hiddev.c | 10 +++++-----
>  include/linux/hid.h         |  2 +-
>  include/linux/hiddev.h      |  2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] HID: hiddev: change hiddev_connect() to return bool Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-10-09 15:10 +0200
  Re: [PATCH v2] HID: hiddev: change hiddev_connect() to return bool Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-13 03:50 +0200

csiph-web