Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device driver

From	Keith Busch <keith.busch@intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device driver
Date	2015-10-12 23:10 +0200
Message-ID	<qiSw1-2oF-9@gated-at.bofh.it> (permalink)
References	<qeQ9r-39m-1@gated-at.bofh.it> <qgJGy-3T4-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 6 Oct 2015, Bjorn Helgaas wrote:
>> +static int __init vmd_init(void)
>> +{
>> +	return pci_register_driver(&vmd_drv);
>> +}
>> +module_init(vmd_init);
>
> module_pci_driver(vmd_drv)?

We actually only have a module_init in this driver, and purposely left
out module_exit. We don't want to be able to unload this because we
can't reference count this module for modules depending on it.

'rmmod <module>' returns busy if you're actively using a device that
module is driving, but the end devices VMD provides are not driven by the
VMD driver; it'd be kind of like being able to unload the pci core driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device driver Bjorn Helgaas <helgaas@kernel.org> - 2015-10-07 01:20 +0200
  Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device  driver Keith Busch <keith.busch@intel.com> - 2015-10-07 02:30 +0200
    Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device  driver Keith Busch <keith.busch@intel.com> - 2015-10-07 18:10 +0200
      Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device driver Bjorn Helgaas <helgaas@kernel.org> - 2015-10-08 15:30 +0200
    Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device driver Bjorn Helgaas <helgaas@kernel.org> - 2015-10-08 15:50 +0200
  Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device  driver Keith Busch <keith.busch@intel.com> - 2015-10-12 23:10 +0200

csiph-web