Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1245098
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs |
| Date | 2015-10-12 22:20 +0200 |
| Message-ID | <qiRJE-1cM-11@gated-at.bofh.it> (permalink) |
| References | <q8AAq-5jh-35@gated-at.bofh.it> <q8ATL-5V5-1@gated-at.bofh.it> <qiHhh-2LN-45@gated-at.bofh.it> <qiNwl-3ks-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi!
On Mon 2015-10-12 16:47:15, Mark Brown wrote:
> On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote:
>
> > Does this look like a step in right direction?
>
> > static const struct regulator_desc arizona_ldo1_hc = {
> > - .name = "LDO1",
>
> No, you definitely shouldn't be doing this - the regulator names should
> reflect the names the device has in the datasheet to aid people in going
> from software to the hardware and back again. They shouldn't be
> dynamically generated at runtime. If you need to namespace by
device
They already are, see wm831x-ldo.c .
> provide an interface which explicitly namespaces by device rather than
> hacking it into another interface, the usual thing is to use the struct
> device as the context.
I'll need some more help here. I need to use it from ALSA, so I don't
think I can influence that interface easily.
What is currently in tree _does not work_, as there are two arizona
chips, and two "LDO1" regulators. (Doable) suggestions how to fix that
are welcome.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Pavel Machek <pavel@ucw.cz> - 2015-10-12 11:10 +0200
Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-10-12 14:00 +0200
Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Mark Brown <broonie@kernel.org> - 2015-10-12 17:50 +0200
Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Pavel Machek <pavel@ucw.cz> - 2015-10-12 22:20 +0200
Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Mark Brown <broonie@kernel.org> - 2015-10-13 14:00 +0200
csiph-web