Re: [Update][PATCH 3/3] input: i8042: Avoid resetting controller on system suspend/resume

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [Update][PATCH 3/3] input: i8042: Avoid resetting controller on system suspend/resume
Date	2015-10-12 22:20 +0200
Message-ID	<qiRJD-1cM-5@gated-at.bofh.it> (permalink)
References	<qedrr-5yV-3@gated-at.bofh.it> <qgJ3Q-2UE-21@gated-at.bofh.it> <qgKVX-5zL-1@gated-at.bofh.it> <qiRgB-nX-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 12, 2015 at 10:17:05PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, October 07, 2015 03:03:57 AM Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > 
> > If the upcoming system suspend is not going to be handled by the
> > platform firmware, like in the suspend-to-idle case, it is not
> > necessary to reset the controller in i8042_pm_suspend(), so avoid
> > doing that.
> > 
> > Moreover, if the system resume currently in progress has not been
> > started by the platform firmware, like in the suspend-to-idle case,
> > i8042_controller_resume() need not be called by i8042_pm_resume(),
> > so avoid doing that too in that case.
> > 
> > Additionally, try to catch the event that woke up the system by
> > calling the interrupt handler early during system resume if it has
> > not been started by the platform firmware.
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> If there are no more comments here, I'll tentatively queue it up for v4.4
> along with the [1-2/3] from this series.
> 
> Please let me know if there are any problems with that.

No problems from my POV.

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] PM / sleep: Make it possible to check if suspend/resume goes via firmware "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-07 00:40 +0200
  [PATCH v3 2/3] PM / PCI / ACPI: Kick devices that might have been reset by firmware "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-07 00:40 +0200
  [RFC][PATCH v3 3/3] input: i8042: Avoid resetting controller on system suspend/resume "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-07 00:40 +0200
    [Update][PATCH 3/3] input: i8042: Avoid resetting controller on system suspend/resume "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-07 02:40 +0200
      Re: [Update][PATCH 3/3] input: i8042: Avoid resetting controller on system suspend/resume "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-12 21:50 +0200
        Re: [Update][PATCH 3/3] input: i8042: Avoid resetting controller on system suspend/resume "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-12 22:20 +0200
        Re: [Update][PATCH 3/3] input: i8042: Avoid resetting controller on  system suspend/resume Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-12 22:20 +0200

csiph-web