Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245027

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

Show all headers | View raw

On Monday 12 October 2015 19:10:10 Robert Jarzmik wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
> > The z2 machine calls pxa27x_set_pwrmode() in order to power off
> > the machine, but this function gets discarded early at boot because
> > it is marked __init, as pointed out by kbuild:
> >
> > WARNING: vmlinux.o(.text+0x145c4): Section mismatch in reference from the function z2_power_off() to the function .init.text:pxa27x_set_pwrmode()
> > The function z2_power_off() references
> > the function __init pxa27x_set_pwrmode().
> > This is often because z2_power_off lacks a __init
> > annotation or the annotation of pxa27x_set_pwrmode is wrong.
> >
> > This removes the __init section modifier to fix rebooting and the
> > build error.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: ba4a90a6d86a ("ARM: pxa/z2: fix building error of pxa27x_cpu_suspend() no longer available")
> > ---
> > This is a fix for an old bug, I'd just put it into 4.4
> >
> > It showed up now because section mismatches now produce errors instead
> > of warnings.
> 
> Hi Arnd,
> 
> I already have this queued for 4.4 from Thierry's patch in :
>   http://www.spinics.net/lists/arm-kernel/msg449414.html
> 
> Yet your patch is more complete, as it deals also with the header in pxa27x.h
> and has the fixes tag.
> 
> Now I'm wondering if I should enhance Thierry's patch with yours and keeping
> your signoff with your permission, or drop Thierry's one to replace by yours (I
> don't know if it's sane behavior to drop an already queued patch ...)

Thierry's patch has no effect unless both the declaration and the use are changed.
Feel free to fix it any way you see fit by rebasing/replacing or adding
the rest of my patch on top.

As long as nobody has picked up your branch into another tree, you can
rebase it, otherwise it has to be done on top. Some people like to never
rebase, others do it all the time and if I see something very wrong in
a branch that I get as a pull request, I will ask for it to be rebased.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: pxa: fix pxa3xx DFI lockup hack Arnd Bergmann <arnd@arndb.de> - 2015-10-12 15:50 +0200
  [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Arnd Bergmann <arnd@arndb.de> - 2015-10-12 15:50 +0200
    Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-12 19:20 +0200
      Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-12 21:00 +0200
        Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Arnd Bergmann <arnd@arndb.de> - 2015-10-12 21:30 +0200
          Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-12 23:20 +0200
            Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Arnd Bergmann <arnd@arndb.de> - 2015-10-13 10:00 +0200
      Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Arnd Bergmann <arnd@arndb.de> - 2015-10-12 21:00 +0200
  Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-12 19:10 +0200
    Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack Arnd Bergmann <arnd@arndb.de> - 2015-10-12 21:00 +0200
    Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack Arnd Bergmann <arnd@arndb.de> - 2015-10-14 17:20 +0200
      Re: [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-14 21:20 +0200

csiph-web