Re: [PATCH] usb: musb: core: add common method of getting vbus status

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: musb: core: add common method of getting vbus status
Date	2015-10-12 18:50 +0200
Message-ID	<qiOsq-4II-21@gated-at.bofh.it> (permalink)
References	<qiLXz-1cm-5@gated-at.bofh.it> <qiMgX-1zC-33@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

Hello.

On 10/12/2015 05:14 PM, Roman Alyautdin wrote:

> Fix musb_platform_get_vbus_status return value in case of platform
> implementation is not defined, bringing expected behaviour of
> musb_platform_get wrapper. Add musb_vbus_show default method to determine
> VBUS status in case platform method is not defined.
>
> Signed-off-by: Roman Alyautdin <ralyautdin@dev.rtsoft.ru>
> ---
>   drivers/usb/musb/musb_core.c |   13 ++++++++++---
>   drivers/usb/musb/musb_core.h |    2 +-
>   2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 4a518ff..3551540 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1771,13 +1771,20 @@ musb_vbus_show(struct device *dev, struct device_attribute *attr, char *buf)
>   	unsigned long	flags;
>   	unsigned long	val;
>   	int		vbus;
> +	u8		devctl;

    I'd add the variable to the block it's used in but this way is OK too.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: musb: core: add common method of getting vbus status Roman Alyautdin <ralyautdin@dev.rtsoft.ru> - 2015-10-12 16:10 +0200
  Re: [PATCH] usb: musb: core: add common method of getting vbus status Roman Alyautdin <ralyautdin@dev.rtsoft.ru> - 2015-10-12 16:20 +0200
  [PATCH] usb: musb: core: add common method of getting vbus status Roman Alyautdin <ralyautdin@dev.rtsoft.ru> - 2015-10-12 16:30 +0200
    Re: [PATCH] usb: musb: core: add common method of getting vbus status Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-12 18:50 +0200

csiph-web