Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap
Date	2015-10-12 18:30 +0200
Message-ID	<qiO96-4kn-53@gated-at.bofh.it> (permalink)
References	<qhAKS-4hU-7@gated-at.bofh.it> <qiIQ1-4TF-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Oct 12, 2015 at 12:48:58PM +0200, Markus Pargmann wrote:
> On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote:

> > +	/* if set, only the cache is modified not the HW */
> > +	bool cache_only;
> > +	/* if set, only the HW is modified not the cache */
> > +	bool cache_bypass;
> > +	/* if set, the cache contains newer data than the HW */
> > +	bool cache_dirty;

> Why are these last three variables just moved and not changed to u8 of
> size 1?

They're exported to debugfs and the relevant debugfs helpers take bool
as an argument (actually I've got a feeling the relevant API is changed
in -next which is likely to be an issue here...).

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC V3] regmap: change bool to 1 bit variable in struct regmap yalin wang <yalin.wang2010@gmail.com> - 2015-10-09 10:00 +0200
  Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap Mark Brown <broonie@kernel.org> - 2015-10-09 13:40 +0200
    Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap yalin wang <yalin.wang2010@gmail.com> - 2015-10-10 03:30 +0200
  Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap Markus Pargmann <mpa@pengutronix.de> - 2015-10-12 12:50 +0200
    Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap Mark Brown <broonie@kernel.org> - 2015-10-12 18:30 +0200

csiph-web