Re: [RFC/PATCH 28/38] perf tools: Move BUILD_ID_SIZE definition to perf.h

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC/PATCH 28/38] perf tools: Move BUILD_ID_SIZE definition to perf.h
Date	2015-10-12 16:40 +0200
Message-ID	<qiMqB-1Ld-11@gated-at.bofh.it> (permalink)
References	<qf14R-2jW-3@gated-at.bofh.it> <qf2DE-4Dq-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 02, 2015 at 03:58:49PM +0900, Namhyung Kim wrote:
> The util/event.h includes util/build-id.h only for BUILD_ID_SIZE.
> This is a problem when I include util/event.h from util/tool.h which
> is also included by util/build-id.h since it now makes a circular
> dependency resulting in incomplete type error.

BUILD_ID_SIZE is build-id.h specific though.. ;-)

how about removing tool.h include from build-id.h
and add just 'struct perf_tool;' declaration

or some other similar fix..

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC/PATCH 28/38] perf tools: Move BUILD_ID_SIZE definition to  perf.h Jiri Olsa <jolsa@redhat.com> - 2015-10-12 16:40 +0200

csiph-web