Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244646

[PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized

Show all headers | View raw

Variables m_thresh and m_dirty in function balance_dirty_pages() may use
uninitialized. GCC throws a warning on it. Fixed by assigned to 0 as
initial value.

Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 0a931cd..288db45 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1534,7 +1534,7 @@ static void balance_dirty_pages(struct address_space *mapping,
 	for (;;) {
 		unsigned long now = jiffies;
 		unsigned long dirty, thresh, bg_thresh;
-		unsigned long m_dirty, m_thresh, m_bg_thresh;
+		unsigned long m_dirty = 0, m_thresh = 0, m_bg_thresh;
 
 		/*
 		 * Unstable writes are a feature of certain networked
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized Liao Tonglang <liaotonglang@gmail.com> - 2015-10-12 14:30 +0200
  Re: [PATCH] mm: cleanup balance_dirty_pages() that leave variables  uninitialized Jan Kara <jack@suse.cz> - 2015-10-12 15:00 +0200
    Re: [PATCH] mm: cleanup balance_dirty_pages() that leave variables  uninitialized Liao Tonglang <liaotonglang@gmail.com> - 2015-10-13 03:50 +0200

csiph-web