Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244642

Re: [PATCH] arm: dts: Fix audio card detection on peach boards

Show all headers | View raw

Hi Sylwester,

On 10/12/2015 02:48 PM, Sylwester Nawrocki wrote:
> On 12/10/15 08:47, Krzysztof Kozlowski wrote:
>>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>>> index 8f4d76c..525a93a 100644
>>>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>>>> @@ -1056,5 +1056,10 @@
>>>>   	timeout-sec = <32>;
>>>>   };
>>>>
>>>> +&pmu_system_controller {
>>
>> Please put the node in alphabetical order.
>>
>>>> +	assigned-clocks = <&pmu_system_controller 0>;
>>>> +	assigned-clock-parents =  <&clock CLK_FIN_PLL>;
>>
>> I might be missing something here but isn't the first clock of
>> pmu_system_controller already a CLK_FIN_PLL? So you are reparenting the
>> FIN_PLL to FIN_PLL?
>
> No, it's not, the first PMU consumer clock is indeed CLK_FIN_PLL,
> but pmu_system_controller is also a clock provider.  The first output
> clock of pmu_system_controller is CLKOUT, it's a composite mux and
> gate clock (registered in drivers/clk/samsung /clk-exynos-clkout.c).
> So  the above dts change is selecting an external oscillator input of
> the CLKOUT mux, i.e. it will route 24 MHz clock signal from the external
> oscillator to the CLKOUT output pin, to which audio CODEC is connected
> on peach-pit AFAICS.
>
Thanks for your explanation, indeed master clock of codec is
connected to XCLKOUT on peach boards.
Will send v2 addressing Kezysztof's other comments.

Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm: dts: Fix audio card detection on peach boards Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-12 08:40 +0200
  Re: [PATCH] arm: dts: Fix audio card detection on peach boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 08:50 +0200
    Re: [PATCH] arm: dts: Fix audio card detection on peach boards Sylwester Nawrocki <s.nawrocki@samsung.com> - 2015-10-12 11:30 +0200
      Re: [PATCH] arm: dts: Fix audio card detection on peach boards Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-12 14:30 +0200
      Re: [PATCH] arm: dts: Fix audio card detection on peach boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 15:00 +0200
    Re: [PATCH] arm: dts: Fix audio card detection on peach boards Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-12 14:30 +0200

csiph-web